-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use embedded build for preview examples #3343
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3343 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2811 2811
Lines 217023 217023
Branches 942 941 -1
==========================================
- Hits 216972 216970 -2
- Misses 51 53 +2 |
This appears to fix |
Thats caused by the bad Buffer polyfil. Not sure where we discussed that. EDIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you extend the [CONTRIBUTING page] with the new script as well?
The other doc scripts aren't listed there either and IMO the command isn't supposed to be called by anybody directly. |
Fixes #3342, #3301 (comment)
internet.jwt()
fails on documentation website #3285This bundles the project into a single file and makes it available to the browser console for
next
and PRs.To keep traffic low on our website and help counting the usage of the versions, the release sites keep using the jsdelivr CDN links.
You can test it using the new language method.